New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use meson-python main branch #6671
Conversation
@@ -1,4 +1,4 @@ | |||
meson-python>=0.11.0 | |||
git+https://github.com/mesonbuild/meson-python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is enough to make cibuildwheel
use meson-python from git. The easiest is probably to patch pyproject.toml
's [build-system]
section.
@jarrodmillman also see the branch I pushed to maintenance last night. |
@stefanv Your approach does not work with cibuildwheel either. Patching |
pyproject.toml
Outdated
@@ -44,7 +44,7 @@ tracker = "https://github.com/scikit-image/scikit-image/issues" | |||
[build-system] | |||
build-backend = "mesonpy" | |||
requires = [ | |||
"meson-python>=0.11.0", | |||
"git+https://github.com/mesonbuild/meson-python", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correct syntax is meson-python @ git+https://github.com/mesonbuild/meson-python
. I would also pin the version, in case future commits to the meson-python git repository break something:
meson-python @ git+https://github.com/mesonbuild/meson-python@babdf709618fbeeaf59634bc2b4331ca5f7924ce"
See #6667
Description
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.x
run-benchmark
label. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.