Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old references to imread package #6680

Merged
merged 1 commit into from Jan 19, 2023

Conversation

jarrodmillman
Copy link
Contributor

Description

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • There is a bot to help automate backporting a PR to an older branch. For
    example, to backport to v0.19.x after merging, add the following in a PR
    comment: @meeseeksdev backport to v0.19.x
  • To run benchmarks on a PR, add the run-benchmark label. To rerun, the label
    can be removed and then added again. The benchmark output can be checked in
    the "Actions" tab.

@jarrodmillman jarrodmillman added this to the 0.20 milestone Jan 18, 2023
@stefanv
Copy link
Member

stefanv commented Jan 19, 2023

@lagru Does it make sense to also deprecate the imread plugin?

@stefanv stefanv merged commit 5de99ec into scikit-image:main Jan 19, 2023
@lagru
Copy link
Member

lagru commented Jan 19, 2023

I'm not sure about the advantages of imread compared to imageio and other plugins? Looking at it, it seems to be a very thin and simple wrapper, so not a huge loss if we remove it. Trying to load the plugin points the user at http://pypi.python.org/pypi/imread/, so I'd also be alright with keeping it even though it's no longer listed in our dependencies. I'm slightly in favor of deprecating it if there aren't any additional benefits.

@stefanv
Copy link
Member

stefanv commented Jan 19, 2023

I'm also +0; it's so lightweight that it doesn't really matter either way.

@jarrodmillman jarrodmillman deleted the imread branch February 17, 2023 19:06
@lagru lagru added the 🔧 type: Maintenance Refactoring and maintenance of internals label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants