Keep deprecated functions available in skimage.filters
#6701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is deprecated, removing it from the module level would break code for users who use the import path skimage.filters.DEPRECATED_FUNC. The whole purpose of a deprecation cycle is to give users the chance to avoid broken code.
lagru
added
🩹 type: Bug fix
lagru
added a commit
to lagru/scikit-image
that referenced
this pull request
Jan 25, 2023
This reverts commit 6131bbb. These changes were moved to scikit-image#6701 in the hope that this can be quickly merged into 0.20.
lagru
changed the title
skimage.filtersskimage.filters
jarrodmillman
approved these changes
Jan 25, 2023
|
Thanks for the quick reviews. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While
compute_hessian_eigenvaluesandinverseare deprecated, removing them from the module level would break code for users who use the import pathskimage.filters.DEPRECATED_FUNC. The whole purpose of a deprecation cycle is to give users the chance to avoid broken code!Drawn out of #6700 in the hope that this can be quickly merged into 0.20.
Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.xrun-benchmarklabel. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.