Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep 0.20.0rc0 #6706

Merged
merged 3 commits into from Jan 27, 2023
Merged

Conversation

jarrodmillman
Copy link
Contributor

Description

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • There is a bot to help automate backporting a PR to an older branch. For
    example, to backport to v0.19.x after merging, add the following in a PR
    comment: @meeseeksdev backport to v0.19.x
  • To run benchmarks on a PR, add the run-benchmark label. To rerun, the label
    can be removed and then added again. The benchmark output can be checked in
    the "Actions" tab.

@jarrodmillman jarrodmillman added this to the 0.20 milestone Jan 27, 2023
Copy link
Member

@stefanv stefanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things that we can address quickly.

doc/release/release_0.20.rst Outdated Show resolved Hide resolved
doc/release/release_0.20.rst Outdated Show resolved Hide resolved
doc/release/release_0.20.rst Outdated Show resolved Hide resolved
doc/release/release_0.20.rst Outdated Show resolved Hide resolved
doc/release/release_0.20.rst Outdated Show resolved Hide resolved

Other and development related updates
-------------------------------------
.. Everything invisible to a user of scikit-image or not covered in the above section. These changes probably not interesting to users.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. Everything invisible to a user of scikit-image or not covered in the above section. These changes probably not interesting to users.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining comments all relate to autogenerated text. I will address this in a future PR after 0.20.0rc0.

- Add a textbook-like tutorial on measuring fluorescence at the nuclear envelope of a cell
(`#5262 <https://github.com/scikit-image/scikit-image/pull/5262>`_).

66 authors added to this release [alphabetical by first name or login]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
66 authors added to this release [alphabetical by first name or login]
66 authors contributed to this release [alphabetical by first name or login]

contributed to? worked on?

- Elena Pascal
- Eli Schwartz
- Fabian Schneider
- forgeRW
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For cases without real names, should we add @ in front?

- Tim-Oliver Buchholz
- Tyler Reddy

37 reviewers added to this release [alphabetical by first name or login]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
37 reviewers added to this release [alphabetical by first name or login]
37 reviewers worked on this release [alphabetical by first name or login]


Other and development related updates
-------------------------------------
.. Everything invisible to a user of scikit-image or not covered in the above section. These changes probably not interesting to users.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably keep these comments? You can maybe just grab the previous release_dev.rst template.

@jarrodmillman jarrodmillman merged commit 918abd3 into scikit-image:main Jan 27, 2023
@jarrodmillman jarrodmillman deleted the prep-0.20.0rc0 branch February 17, 2023 19:06
@lagru lagru added the 🔧 type: Maintenance Refactoring and maintenance of internals label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants