Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fstring #6733

Merged
merged 1 commit into from Feb 4, 2023
Merged

Fix fstring #6733

merged 1 commit into from Feb 4, 2023

Conversation

jarrodmillman
Copy link
Contributor

@jarrodmillman jarrodmillman commented Feb 4, 2023

Fix #6730

Before

$ python
Python 3.9.9 (main, Nov 19 2021, 00:00:00)
[GCC 10.3.1 20210422 (Red Hat 10.3.1-1)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> remaining = ["t", "s"]
>>> msg = f"No warning raised matching:\n{{'\n'.join(remaining)}}"
>>> print(msg)
No warning raised matching:
{'
'.join(remaining)}

After

$ python
Python 3.9.9 (main, Nov 19 2021, 00:00:00)
[GCC 10.3.1 20210422 (Red Hat 10.3.1-1)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> remaining = ["t", "s"]
>>> newline = "\n"
>>> msg = f"No warning raised matching:{newline}{newline.join(remaining)}"
>>> print(msg)
No warning raised matching:
t
s

@jarrodmillman jarrodmillman added this to the 0.20 milestone Feb 4, 2023
@stefanv stefanv merged commit 333e629 into scikit-image:main Feb 4, 2023
@jarrodmillman jarrodmillman deleted the fstring-newline branch February 17, 2023 19:06
@lagru lagru added the 🔧 type: Maintenance Refactoring and maintenance of internals label Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid f-string in _warnings
3 participants