Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy-paste error in footprints.diamond test case #6756

Merged
merged 1 commit into from Mar 6, 2023

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Feb 16, 2023

This MR fixes what appears to be a copy/paste error in the morphology tests. Diamond footprint test cases were actually not using the diamond footprint at all and were just duplicating the square footprint tests!

@grlee77 grlee77 added the 🩹 type: Bug fix Fixes unexpected or incorrect behavior label Feb 16, 2023
Copy link
Member

@lagru lagru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@lagru lagru merged commit 534e897 into scikit-image:main Mar 6, 2023
@lagru lagru changed the title Fix duplicate gray morphology test case Fix copy-paste error in footprints.diamond test case Mar 6, 2023
@lagru lagru added this to the 0.21 milestone Mar 6, 2023
@lagru lagru added the 🔧 type: Maintenance Refactoring and maintenance of internals label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🩹 type: Bug fix Fixes unexpected or incorrect behavior 🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants