New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docstring to the transform
module
#6797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, nice work @rum1887! That's a lot more detailed than what I would have anticipated and already reads quite well. We could include this as is, however with how detailed it is I fear it might get outdated quickly.
What do you think about restructuring things a bit to have a more natural flow? Maybe something like the following that includes what you wrote but in a more general style that's less focused on the implementation and more on the purpose.
"This module includes tools to transform images and volumetric data such as:
- Geometric transformations can manipulate the shape and position of an image and are useful for tasks such as image registration, alignment, and geometric correction.
- ...
"
I agree that it might get outdated :) How about providing a few functions as examples under each category for ease of understanding instead of an exhaustive list of functions available at scikit-image.tranform module? Maybe I could add a note mentioning that the examples are not exhaustive and point them to the documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rum1887, thanks. This is shaping up! :) I've left a few more suggestions.
@lagru Do review this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and almost ready! Except for the comment on capitalization I'm happy to approve.
skimage.transform
module
skimage.transform
moduletransform
module
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, done. :) Thank you @rum1887!
Hey @mkcor, taking the liberty to ping you here. I think this can be merged or is nearly done depending on your review. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skimage/transform/__init__.py
Outdated
These transforms change the appearance of an image without changing its | ||
content. They are useful for tasks such a creating image mosaics, | ||
applying artistic effects, and visualizing image data. | ||
Examples: :func:`~skimage.transform.warp`, inverse transforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually (see all the rest above), what's under 'Examples' are specific (linked to) functions or classes... Why are 'inverse transforms' in the wild like this? 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably because there are multiple iradon*
function's to link to and it wasn't clear which one. I would probably just link iradon
as a well-known example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably because there are multiple
iradon*
function's to link to and it wasn't clear which one. I would probably just linkiradon
as a well-known example.
Usually (see all the rest above), what's under 'Examples' are specific (linked to) functions or classes... Why are 'inverse transforms' in the wild like this? 😉
yeah , was not sure which inverse transform to link to , so didn't link to keep it more general.
Since these are just examples , linking to a well known function would also work.
Thanks a lot for your review , learnt a lot and had a great time working on this !
Co-authored-by: Marianne Corvellec <marianne.corvellec@ens-lyon.org>
Thanks @rum1887! |
Description
Added Docstring to the transform module. Updates the issue #6761
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.x
run-benchmark
label. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.