Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error in skeletonize for invalid value to method param #6805

Merged
merged 5 commits into from Mar 13, 2023
Merged

Raise error in skeletonize for invalid value to method param #6805

merged 5 commits into from Mar 13, 2023

Commits on Mar 9, 2023

  1. Added an elif condition to throw the required error

    @rum1887
    rum1887 committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    15f17a6 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Update skimage/morphology/_skeletonize.py 

    PEP8 styleguide

Co-authored-by: Juan Nunez-Iglesias <jni@fastmail.com>
    @rum1887 @jni
    rum1887 and jni committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    ffa026f View commit details
    Browse the repository at this point in the history

  2. unit test added for invalid-skeletonize method

    @rum1887
    rum1887 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    3584734 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2023

  1. PEP8 formatting

    @jni
    jni committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    6d16b27 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2023

  1. Move parameter check to independent if-clause 

    Not really a fan of the logic in this function. At the very least I
think we can make it a bit easier to reason about if we make the input
guard for the "method" parameter its own independent if-clause.
    @lagru
    lagru committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    b7dc75d View commit details
    Browse the repository at this point in the history