Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _warps_cy.pyx #6867

Merged
merged 1 commit into from Apr 5, 2023
Merged

Update _warps_cy.pyx #6867

merged 1 commit into from Apr 5, 2023

Conversation

23pointsNorth
Copy link
Contributor

Was trying to debug why when warping a 3-channel image, cval cannot be a list/tuple of [R,G,B] values. Update cval internal type in docstring. Happy for this change to be incorporated alongside some other delta and this closed.

Description

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • There is a bot to help automate backporting a PR to an older branch. For
    example, to backport to v0.19.x after merging, add the following in a PR
    comment: @meeseeksdev backport to v0.19.x
  • To run benchmarks on a PR, add the run-benchmark label. To rerun, the label
    can be removed and then added again. The benchmark output can be checked in
    the "Actions" tab.

Update cval internal type in docstring
@jarrodmillman jarrodmillman added this to the 0.21 milestone Apr 5, 2023
@stefanv stefanv merged commit 4fd899c into scikit-image:main Apr 5, 2023
22 checks passed
@lagru lagru added the 📄 type: Documentation Updates, fixes and additions to documentation label Apr 5, 2023
@23pointsNorth 23pointsNorth deleted the patch-1 branch July 31, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants