Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing backticks to DOI role in docstring of area_opening #6913

Merged
merged 1 commit into from Apr 27, 2023

Conversation

lagru
Copy link
Member

@lagru lagru commented Apr 27, 2023

Description

It was pointed out in #6714 (comment), that these were not rendering properly. Also tweak the text on the Gallery landing page as pointed out in #6714 (comment).

cc @stefanv

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • There is a bot to help automate backporting a PR to an older branch. For
    example, to backport to v0.19.x after merging, add the following in a PR
    comment: @meeseeksdev backport to v0.19.x
  • To run benchmarks on a PR, add the run-benchmark label. To rerun, the label
    can be removed and then added again. The benchmark output can be checked in
    the "Actions" tab.

It was pointed out in [1], that these were not rendering properly.
Also tweak the text on the Gallery landing page as pointed out in [2].

[1] scikit-image#6714 (comment)
[2] scikit-image#6714 (comment)
@lagru lagru added 📄 type: Documentation Updates, fixes and additions to documentation 🩹 type: Bug fix Fixes unexpected or incorrect behavior labels Apr 27, 2023
@stefanv stefanv merged commit f551579 into scikit-image:main Apr 27, 2023
23 of 24 checks passed
@lagru lagru deleted the fix-doi-roles branch April 28, 2023 08:05
@jarrodmillman jarrodmillman added this to the 0.21 milestone May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🩹 type: Bug fix Fixes unexpected or incorrect behavior 📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants