New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable testing against nightly upstream wheels #6956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good, thanks for doing these updates.
Also, add a development
, or the magic "fix" word that this closes #6956
Also, it was pointed out to me, this solution using |
This test raised a DeprecationWarning: It is deprecated to return a value that is not None from a test case.
32db8a7
to
d3501ab
Compare
One thing I'm not sure about is whether we want to test nightly wheels on every pull request. I don't want contributors to get confused and frustrated because they are assuming it's something they did. So we could turn this into a regular actions that's only triggered for |
@jarrodmillman, this should be ready to merge now. |
Description
See https://github.com/scientific-python/upload-nightly-action#using-nightly-builds-in-ci
Somewhat related #6514.
cc @bsipocz, @jarrodmillman
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.x
run-benchmark
label. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.