Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testing against nightly upstream wheels #6956

Merged
merged 5 commits into from May 24, 2023

Conversation

lagru
Copy link
Member

@lagru lagru commented May 23, 2023

Description

See https://github.com/scientific-python/upload-nightly-action#using-nightly-builds-in-ci

Somewhat related #6514.

cc @bsipocz, @jarrodmillman

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • There is a bot to help automate backporting a PR to an older branch. For
    example, to backport to v0.19.x after merging, add the following in a PR
    comment: @meeseeksdev backport to v0.19.x
  • To run benchmarks on a PR, add the run-benchmark label. To rerun, the label
    can be removed and then added again. The benchmark output can be checked in
    the "Actions" tab.

@lagru lagru added the 🤖 type: Infrastructure CI, packaging, tools and automation label May 23, 2023
Copy link
Contributor

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, thanks for doing these updates.

Also, add a development, or the magic "fix" word that this closes #6956

@lagru
Copy link
Member Author

lagru commented May 24, 2023

Also, add a development, or the magic "fix" word that this closes #6956

Not sure what you mean? "#6956" is this PR?

@lagru
Copy link
Member Author

lagru commented May 24, 2023

Also, it was pointed out to me, this solution using --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple isn't expected to include all nightly wheels right now. But it's expected upstream projects like NumPy will start providing wheels there. You can see under https://pypi.anaconda.org/scientific-python-nightly-wheels/simple/ which nightly wheels are already available...

This test raised a DeprecationWarning: It is deprecated to return a
value that is not None from a test case.
@lagru
Copy link
Member Author

lagru commented May 24, 2023

One thing I'm not sure about is whether we want to test nightly wheels on every pull request. I don't want contributors to get confused and frustrated because they are assuming it's something they did. So we could turn this into a regular actions that's only triggered for main like networkx did, but others pointed out that then there are no automatic notifications for everyone if there is a failure...

@lagru
Copy link
Member Author

lagru commented May 24, 2023

@jarrodmillman, this should be ready to merge now.

@jarrodmillman jarrodmillman added this to the 0.21 milestone May 24, 2023
@jarrodmillman jarrodmillman merged commit 821c9f2 into main May 24, 2023
37 checks passed
@lagru lagru deleted the test-with-nightly-deps branch May 24, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 type: Infrastructure CI, packaging, tools and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants