New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lazy loading to skimage.color submodule #6967
Merged
lagru
merged 14 commits into
scikit-image:main
from
decorouz:lazy_loader_color_submodule
May 31, 2023
Merged
Add lazy loading to skimage.color submodule #6967
lagru
merged 14 commits into
scikit-image:main
from
decorouz:lazy_loader_color_submodule
May 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lars Grüter <lagru+github@mailbox.org>
Co-authored-by: Lars Grüter <lagru+github@mailbox.org>
Co-authored-by: Lars Grüter <lagru+github@mailbox.org>
stefanv
reviewed
May 30, 2023
skimage/morphology/__init__.py
Outdated
@@ -1,3 +1,11 @@ | |||
"""Utilities that process images based on shapes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove changes to this file from this PR.
Thanks @decorouz! This PR looks good to me. There's one file that shouldn't have been committed, otherwise we can go ahead and merge. |
lagru
changed the title
Add lazy loading to skimage.color submodule #6966
Add lazy loading to skimage.color submodule
May 31, 2023
lagru
added
📈 type: Performance
👋 Outreachy
and removed
🔧 type: Maintenance
Refactoring and maintenance of internals
labels
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add lazy loader to
skimage.color
submodule. #6964Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.x
run-benchmark
label. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.