Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lazy loading to skimage.color submodule #6967

Merged
merged 14 commits into from May 31, 2023

Conversation

decorouz
Copy link
Contributor

Description

Add lazy loader to skimage.color submodule. #6964

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • There is a bot to help automate backporting a PR to an older branch. For
    example, to backport to v0.19.x after merging, add the following in a PR
    comment: @meeseeksdev backport to v0.19.x
  • To run benchmarks on a PR, add the run-benchmark label. To rerun, the label
    can be removed and then added again. The benchmark output can be checked in
    the "Actions" tab.

@stefanv stefanv added the 🔧 type: Maintenance Refactoring and maintenance of internals label May 30, 2023
@@ -1,3 +1,11 @@
"""Utilities that process images based on shapes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove changes to this file from this PR.

@stefanv
Copy link
Member

stefanv commented May 30, 2023

Thanks @decorouz! This PR looks good to me. There's one file that shouldn't have been committed, otherwise we can go ahead and merge.

@lagru lagru changed the title Add lazy loading to skimage.color submodule #6966 Add lazy loading to skimage.color submodule May 31, 2023
@lagru lagru merged commit 2127719 into scikit-image:main May 31, 2023
22 checks passed
@lagru
Copy link
Member

lagru commented May 31, 2023

Thanks @decorouz. Hope it was okay to merge this despite the pending release; I took @stefanv's comment as an indicator that it was okay.

@lagru lagru added 📈 type: Performance 👋 Outreachy and removed 🔧 type: Maintenance Refactoring and maintenance of internals labels May 31, 2023
@jarrodmillman jarrodmillman added this to the 0.21 milestone May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants