New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lazy loading to skimage.draw submodule #6971
Add Lazy loading to skimage.draw submodule #6971
Conversation
Co-authored-by: Lars Grüter <lagru+github@mailbox.org>
Co-authored-by: Lars Grüter <lagru+github@mailbox.org>
Co-authored-by: Lars Grüter <lagru+github@mailbox.org>
…nto lazy_loader_draw_submodule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks looks good.
By the way @decorouz, your pull request seem to include unnecessary commits. How are you creating these feature branches? The common workflow to create a feature branch is usually: git checkout main
git pull upstream main # Pull new changes
git checkout -b feature-branch # Create new feature branch If you ever need to incorporate new changes from # Assumes you are already on the feature branch!
git fetch upstream
git fetch . upstream/main:main # Fast-forward merge local main without switching branches
git merge main |
Interesting, I can't reproduce the import error locally... 🤔 |
@decorouz I pushed an attempt to fix this. Please update your local branch with
before you add new changes locally. |
@lagru Thanks for the review and fix. I figured I messed up the flow for incorporating new changes from main. I just didn't know how to fix it. Thanks for the suggestion. I have saved in a note for future reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is happy now.
Thanks, @decorouz! |
Description
Add lazy loading to
skimage.draw
submodule. #6964Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.x
run-benchmark
label. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.