Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to numpy>=1.23 and matplotlib>=3.6 according to SPEC 0 #7284

Merged
merged 1 commit into from Jan 9, 2024

Conversation

jarrodmillman
Copy link
Contributor

@jarrodmillman jarrodmillman commented Jan 9, 2024

Description

Checklist

Release note

Summarize the introduced changes in the code block below in one or a few sentences. The
summary will be included in the next release notes automatically:

...

@jarrodmillman jarrodmillman added the 🔧 type: Maintenance Refactoring and maintenance of internals label Jan 9, 2024
Copy link
Member

@lagru lagru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lagru lagru merged commit fadbe91 into scikit-image:main Jan 9, 2024
23 of 24 checks passed
@stefanv stefanv added this to the 0.23 milestone Jan 9, 2024
@lagru lagru changed the title Drop old dependencies per SPEC 0 Update to numpy>=1.23 and matplotlib>=3.6 according to SPEC 0 Jan 9, 2024
@lagru lagru added 📜 type: API Involves API change(s) 🔧 type: Maintenance Refactoring and maintenance of internals and removed 🔧 type: Maintenance Refactoring and maintenance of internals 📜 type: API Involves API change(s) labels Jan 9, 2024
@stefanv
Copy link
Member

stefanv commented Jan 9, 2024

@lagru Did you notice that CI was red on that one?

@lagru
Copy link
Member

lagru commented Jan 9, 2024

Yes, I've been seeing this error for the pre-job in other PRs as well and was reasonably sure that this PR didn't introduce it. Haven't yet looked into whats triggering it...

For future reference, should I have held of one the merge regardless in this case?

@stefanv
Copy link
Member

stefanv commented Jan 9, 2024

Ah, no, just want to make sure it gets looked at; I will also investigate. Merging this to main caused that branch to now fail.

@lagru
Copy link
Member

lagru commented Jan 10, 2024

I can reproduce the error locally for Python 3.12. Pytest 8.0.0rc1 (as opposed to 7.4.4) seems to trigger it.

@lagru
Copy link
Member

lagru commented Jan 10, 2024

I think it's because starting with 8.0.0rc1 pytest now re-emits warnings it didn't match. Previously these were silently consumed. :/ Search for #9288 in https://docs.pytest.org/en/latest/changelog.html. So it's not a new warning, it's that we are seeing it now.

@lagru
Copy link
Member

lagru commented Jan 10, 2024

See #7287.

@lagru lagru mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants