New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include border when generating basin markers for watershed #7362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mkcor. Looks already good to me so feel welcome to ignore my other minor suggestions at will. :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are at it, do you want to switch this over to import skimage as ski
? I'd happily review that. 😉
Also, while reviewing this again: is "dichotomy" a well known term? A bit of topic, but rewording that might improve the example also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are at it, do you want to switch this over to
import skimage as ski
? I'd happily review that. 😉
Done! facda52
Also, while reviewing this again: is "dichotomy" a well known term? A bit of topic, but rewording that might improve the example also.
I remember learning about this approach in my K-12 education, so I wouldn't consider it hyper-specialized...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit weird that the order with which the subplots are created for the over- and underestimation plot is not identical with the with index and plotted order? Maybe reorder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure: bf81710
Co-authored-by: Lars Grüter <lagru+github@mailbox.org>
Thanks @mkcor! Merging since this improvement to the gallery probably doesn't need a third maintainer to approve and has been open for some time. |
Description
Here I'm updating the Segment human cells in mitosis (link to stable):
Checklist
./doc/examples
for new featuresRelease note
We use changelist to
compile each pull request into an item of the release notes. Please refer to
the instructions
and past release notes
for guidance and examples.