Add back support for python 3.9 for numpy 2 compatibility woes #7412
Conversation
hmaarrfk
force-pushed
the
support_python3.9
branch
from
c5dd7cc
to
c85c3d2
Compare
|
i expected some tests to fail, but I did not expect them to catastrophically fail like this on CPython 3.9 |
hmaarrfk
force-pushed
the
support_python3.9
branch
3 times, most recently
from
d8973a3
to
41e271e
Compare
| @@ -747,10 +747,11 @@ def test_inverse_all_transforms(tform): | |||
| assert_almost_equal(tform.inverse.inverse(SRC), tform(SRC)) | |||
| # Test addition with inverse, not implemented for all | |||
| if not isinstance( | |||
| tform, | |||
| EssentialMatrixTransform | |||
| | FundamentalMatrixTransform | |||
There was a problem hiding this comment.
man, this syntax is really strange...
There was a problem hiding this comment.
FYI it seems that this was added by some autofromatting code
@jarrodmillman is there a way for me to disable this kind of syntax reformatting?
|
I think this is ready again for review. While I was very hopeful that NEP29/SPEC0 could be adhered to, I feel like we might need to rethink the general strategy of: "Does numpy continue support the longest" Given the likely release of Numpy2 for Python 3.9, I think we should continue to support it, at least until the major bugs have been caught with it. |
|
I'm personally not opposed to making a last release to support 3.9. 👍 |
|
But I'd probably prefer a patch release 0.23.3 with the relevant commits cherry-picked. I'm not sure what you are suggesting as a new version otherwise in
|
|
There are two options in my mind:
I'm providing the option for 0.23.3 since I think that getting the CIs working for 0.22.X will be hard. The work on the LTS still haunts me. |
It seems highly probable that numpy 2 will release a build for Python 3.9 @rgommers had asked us to add an upper bound to our releases in Jan but it seems that we didn't take action (understanding how pip solves packages is unclear to me even). Instead of releasing 0.22.1 for python 3.9 with metadata updates, i'm curious to see if we can release a new version with python 3.9. The headache of getting CIs working is what I'm hoping to avoid with this startegy xref: https://mail.python.org/archives/list/numpy-discussion@python.org/thread/AHTATJKGUEOILBNUI5IGGZPXJ5FXIRAU/
hmaarrfk
force-pushed
the
support_python3.9
branch
from
fb51b6f
to
29d9550
Compare
|
The CIs are green. Any interest in moving on this? |
|
I'd like to have @jarrodmillman weigh in. |
It seems highly probable that numpy 2 will release a build for Python 3.9
@rgommers had asked us to add an upper bound to our releases in Jan but it seems that we didn't take action (understanding how pip solves packages is unclear to me even).
Instead of releasing 0.22.1 for python 3.9 with metadata updates, i'm curious to see if we can release a new version with python 3.9.
The headache of getting CIs working is what I'm hoping to avoid with this startegy
xref: https://mail.python.org/archives/list/numpy-discussion@python.org/thread/AHTATJKGUEOILBNUI5IGGZPXJ5FXIRAU/
xref: #7282 (comment)
Checklist
./doc/examplesfor new featuresRelease note
For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.