-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix doctests and let TravisCI run doctests #811
Merged
Merged
Changes from all commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
f4b211f
Add make instruction for doctest
ahojnnes 313c444
Let travis run doctests
ahojnnes 610f589
Fix corner doc tests
ahojnnes 40fc5d2
Fix corner_subpix function for corners near border
ahojnnes dc35d3d
Add example for corner_subpix function
ahojnnes c7fbd32
Fix doctest of remove_small_objects
ahojnnes facc8f5
Fix watershed doctest
ahojnnes 87dcaa4
Fix hough_line_peaks doctest
ahojnnes c737861
Fix block_reduce doctest
ahojnnes 41d1246
Fix RANSAC doctest
ahojnnes 45eae57
Use NORMALIZE_WHITESPACE directive for block_reduce doctest
ahojnnes 256a0ba
Fix montage2d doctest
ahojnnes 411de75
Remove plotter from doctest and use comparison to np.histogram instead
ahojnnes d726a54
Fix precision of output in hough_line_peaks doctest
ahojnnes 80ec4fc
Install nose from PyPI
ahojnnes 326557e
Remove unnecessary coverage directive
ahojnnes 31b52e9
Install PyQt4 for doctests
ahojnnes 757c081
Install Cython from apt
ahojnnes bf82a0a
Fix PyQt4 for python 3
ahojnnes 7bf858c
Install xserver
ahojnnes 0f303a2
Install Cython via pip
ahojnnes cc33e53
Use xvfb rather than xorg
ahojnnes 0e32735
Do not change into a separate directory for testing
ahojnnes 66219e8
Build extensions in-place
ahojnnes 1dc346f
Fix duplicate percentile names rank namespace
ahojnnes e92f415
Fix duplicate find_contours names in namespace
ahojnnes 5038a0e
Remove numpy prefix from pad function examples
ahojnnes f038a95
Skip ransac doctests
ahojnnes 20e8e72
Only build in-place
ahojnnes 8047d5f
Update bento.info
ahojnnes 8daeb65
Fix novice doctests
ahojnnes 2e7f14d
Fix multi image doctest
ahojnnes 23444a5
Explicitly cast window extent to integer for python 3
ahojnnes 753cc6f
Fix novice doctest
ahojnnes 6e6ca86
Fix corner_foerstner doctest
ahojnnes 8b74ab4
Fix python 3 syntax error
ahojnnes a1fcc65
Also run doc tests for files with a leading underscore
ahojnnes b7b391c
Temporarily disable brief test cases and ignore test files with a lea…
ahojnnes c6f9b53
Fix rank order doc test
ahojnnes 099b428
Fix marching_cubes doctest
ahojnnes ad0347d
Fix regionprops doctest
ahojnnes dd572a6
Fix medial_axis and skeletonize doctests
ahojnnes 591aa08
Fix geometric doctests
ahojnnes 0dd36ab
Fix downscale_local_means doctest
ahojnnes aaf0749
Fix hough_line_peaks doctest
ahojnnes 863e89b
Fix data type issue in python 3
ahojnnes bb1f7df
Improve usage of doctest directives
ahojnnes dd06dc8
Use a better way to comment out the brief examples temporarily
ahojnnes e282b3e
Revert ellipsis to skip directive
ahojnnes 64e21e9
Use travis-ci python config
ahojnnes f76f06c
Discard pip installation and install matplotlib from PyPI
ahojnnes 49fc67c
Simplify travis config
ahojnnes 4fa7b5b
Touch non-existent matplotlibrc
ahojnnes 729c38c
Fix matplotlibrc configuration
ahojnnes a242f00
Add python 2.6 and 3.3 environments
ahojnnes c9a0e53
Remove python 2.6 and 3.3
ahojnnes 615866a
Cast label_field to integer dtype for float intput
ahojnnes 7f27d5b
Fix label2rgb bug
ahojnnes fb1c1d3
Fix misspelled sections
ahojnnes ad34647
Fix doc string syntax errors
ahojnnes f651cba
Reduce runtime of daisy visualization test case
ahojnnes f8a0fcb
Reduce runtime of radon test cases
ahojnnes b4c190e
Explicitly set sigma value to 0 to avoid warning
ahojnnes 3b1182c
Skip show commands for doc tests
ahojnnes 825ebdf
Add note about disabled doctests
ahojnnes ffc28d1
Enable doc tests of ransac function
ahojnnes 4566c36
Add doctest function to skimage
ahojnnes b1d146d
Use skimage test functions instead of nose commandline
ahojnnes 307725e
Add --exe directive to doc test
ahojnnes e472528
Return correct exit code for tests
ahojnnes b9b50dc
Make sure stdlib io is not shadowed by skimage.io
ahojnnes 2bc4cf6
Skip failing ransac doctest
ahojnnes df4ca92
Reduce runtime of long doctests
ahojnnes 12d2e9a
Fix indentation
ahojnnes 83f7f37
Use explicit interger division
ahojnnes File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change this to just two greater-thans?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because for the time being (not working right now) those tests must be skipped, and the simplest way is to use >>.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, you've used
# doctest: +SKIP
elsewhere, why not here? I think that explicit flag is much better for readability.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brief is currently hidden from the public as an experimental function until we merge Ankit's branch #699. It was just easier for now to disable them this way temporarily. They will be reenabled shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a satisfactory solution for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um... That depends... How is it "hidden"? (Sorry, I only skimmed that discussion.) Isn't it possible to make doctest as a whole skip the entire file? This seems hacky. At any rate, I'm semi-happy to allow it but I'd like a +1 from e.g. @stefanv. =)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with this as long as we note it somewhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. in todo.txt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, or in a ticket--either is fine.