Remove random-gallery #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lagru
approved these changes
May 13, 2023
|
No, this was the random gallery image on the front page. Front page rendering is now also broken for the header. Please revert. |
lagru
added a commit
that referenced
this pull request
May 13, 2023
This reverts commit 6d76fcc which broke the header rendering and the random gallery example on the front page [1]. [1] #85 (comment)
|
Reverted in 0315c27. I'll revert the appropriate parts in scikit-image/scikit-image#6933 next. Sorry for the mistake. |
lagru
added a commit
to lagru/scikit-image
that referenced
this pull request
May 13, 2023
This script was removed in scikit-image#6933 [1] even though it is still in use on our front page [2]! Therefore revert this particular change of scikit-image#6933. [1] scikit-image#6933 [2] scikit-image/skimage-web#85
jarrodmillman
pushed a commit
to scikit-image/scikit-image
that referenced
this pull request
May 15, 2023
* Revert removal of random gallery script This script was removed in #6933 [1] even though it is still in use on our front page [2]! Therefore revert this particular change of #6933. [1] #6933 [2] scikit-image/skimage-web#85 * Merge random.js generation into sphinx_extensions.py Previously, `gallery_random.py` would generate the appropriate `random.js` file with the `source/_static` as the target folder after Sphinx itself was done. However, this meant that `random.js` would not be included in our CI's build artifacts (locally it's included if sphinx is run a second time). Inclusion in skimage_extensions.py with a trigger on the Sphinx event "build-finished" ensures that the appropriate output path can be determined from Sphinx's configuration. This inclusion seems to have been broken at least since 2020-08-15 [2]. [2] http://web.archive.org/web/20200815074104/https://scikit-image.org/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See scikit-image/scikit-image@d662017
As far as I can tell, this is cruft and should be removed.