Fix inclusion of random.js in HTML output
#6935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script was removed in scikit-image#6933 [1] even though it is still in use on our front page [2]! Therefore revert this particular change of scikit-image#6933. [1] scikit-image#6933 [2] scikit-image/skimage-web#85
lagru
added
🤖 type: Infrastructure
|
Wayback machine indicates that this broke between 2020-07-27 and 2020-08-15, though I can't find anything that looks like the cause in the commit history. @stefanv do you remember how the generated Anyway I think I know why it isn't included. Lines 49 to 53 in 84bd082 There is nothing copying it to |
Previously, `gallery_random.py` would generate the appropriate `random.js` file with the `source/_static` as the target folder after Sphinx itself was done. However, this meant that `random.js` would not be included in our CI's build artifacts (locally it's included if sphinx is run a second time). Inclusion in skimage_extensions.py with a trigger on the Sphinx event "build-finished" ensures that the appropriate output path can be determined from Sphinx's configuration. This inclusion seems to have been broken at least since 2020-08-15 [2]. [2] http://web.archive.org/web/20200815074104/https://scikit-image.org/
|
Okay, it's included now (see artifacts). |
lagru
changed the title
random.js in HTML output
jarrodmillman
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This script was removed in #6933 even though it is still in use on our front page (see scikit-image/skimage-web#85)! Therefore revert this particular change of #6933.
Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.xrun-benchmarklabel. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.