Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sum taken over wrong axis #104

Closed
bchugg opened this issue Jun 3, 2021 · 3 comments
Closed

Sum taken over wrong axis #104

bchugg opened this issue Jun 3, 2021 · 3 comments

Comments

@bchugg
Copy link

bchugg commented Jun 3, 2021

Hi there,

I believe the centered predictions are being computed incorrectly. Line 278 in forestci.py takes the average over the predictions, as opposed to the trees. The resulting shape of pred_mean is (forest.n_estimators,) when it should be (X_test.shape[0],). See below:

pred_centered = pred - pred_mean

Thanks for the great package otherwise! :)

@nikaashpuri
Copy link

are there any thoughts on this one?

@nikaashpuri
Copy link

please check #80

@danieleongari
Copy link
Collaborator

pred_mean is correct to compute the variance of pred. I guess you missed that the matrix pred is trasposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants