Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set/update the preprocessor outside the init #215

Open
wdevazelhes opened this issue Jun 12, 2019 · 1 comment
Open

set/update the preprocessor outside the init #215

wdevazelhes opened this issue Jun 12, 2019 · 1 comment

Comments

@wdevazelhes
Copy link
Member

wdevazelhes commented Jun 12, 2019

Just a thought, but it might be useful to have a function to update/set the preprocessor outside of the init. Right now it is just initialized when calling fit (so using sth like mcc.set_params(preprocessor=X) won't help). But one might realize later after fitting that they need a/another preprocessor, for instance if they want to score_pairs on a huge dataset, or maybe if they want to score_pairs on a different dataset than the one they used at fit time.

@bellet
Copy link
Member

bellet commented Jun 12, 2019

I think we thought about that and this is why we still allow the user to submit pairs in feature form instead of id even when a preprocessor has been initialized

But we could add such an option for convenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants