fixed copy parameter in TfidfVectorizer #14808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in TfidfVectorizer.transform the copy parameter is never used, and is just set to False inside the function. This PR fixes that, although I have left the default parameter to copy=True, even though the current behaviour has been copy=False.
lrjball
changed the title
|
Thanks, but this was fixed by deprecating the |
|
Apologies, I noticed this a couple of weeks ago and only just got round to a PR, must have missed that change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in TfidfVectorizer.transform the copy parameter is never
used, and is just set to False inside the function. This PR fixes
that, although I have left the default parameter to copy=True, even
though the current behaviour has been copy=False.