Skip to content

/ scikit-learn

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG+1] Add data_home parameter to fetch_kddcup99 #9289

Merged
merged 1 commit into from Jul 6, 2017
Merged

[MRG+1] Add data_home parameter to fetch_kddcup99 #9289

merged 1 commit into from Jul 6, 2017

Conversation

@lesteve
Copy link
Member

@lesteve lesteve commented Jul 6, 2017

What does this implement/fix? Explain your changes.

data_home is present in all the fetchers but fetch_kddcup99.
@lesteve
Copy link
Member Author

@lesteve lesteve commented Jul 6, 2017

Note I tested this locally, but this is not covered by any test.
@lesteve
Add data_home parameter to fetch_kddcup99
Loading status checks…
5a3dc75
@lesteve lesteve force-pushed the lesteve:add-data-home-to-fetch-kddcup99 branch from 3ad0c16 to 5a3dc75 Jul 6, 2017
@agramfort
Copy link
Member

@agramfort agramfort commented Jul 6, 2017

LGTM !
@agramfort agramfort changed the title [MRG] Add data_home parameter to fetch_kddcup99 [MRG+1] Add data_home parameter to fetch_kddcup99 Jul 6, 2017
@TomDLT TomDLT merged commit 587bf3a into scikit-learn:master Jul 6, 2017
5 checks passed
5 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.36%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +3.63% compared to 51c8c16
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
massich added a commit to massich/scikit-learn that referenced this pull request Jul 13, 2017
@lesteve @massich
Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
92c34f7
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017
@yarikoptic
Merge tag '0.19b2' into releases
ec9e5de 
Release 0.19b2

* tag '0.19b2': (808 commits)
  Preparing 0.19b2
  [MRG+1] FIX out of bounds array access in SAGA (scikit-learn#9376)
  FIX make test_importances pass on 32 bit linux
  Release 0.19b1
  DOC remove 'in dev' header in whats_new.rst
  DOC typos in whats_news.rst [ci skip]
  [MRG] DOC cleaning up what's new for 0.19 (scikit-learn#9252)
  FIX t-SNE memory usage and many other optimizer issues (scikit-learn#9032)
  FIX broken link in gallery and bad title rendering
  [MRG] DOC Replace \acute by prime (scikit-learn#9332)
  Fix typos (scikit-learn#9320)
  [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (scikit-learn#9206)
  DOC Residual sum vs. regression sum (scikit-learn#9314)
  [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (scikit-learn#9317)
  More informative error message for classification metrics given regression output (scikit-learn#9275)
  [MRG] COSMIT Remove unused parameters in private functions (scikit-learn#9310)
  [MRG+1] Ridgecv normalize (scikit-learn#9302)
  [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (scikit-learn#7388)
  Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
  FIX makedirs(..., exists_ok) not available in Python 2 (scikit-learn#9284)
  ...
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017
@yarikoptic
Merge branch 'releases' into dfsg (reremoved joblib and jquery)
4615112 
* releases: (808 commits)
  Preparing 0.19b2
  [MRG+1] FIX out of bounds array access in SAGA (scikit-learn#9376)
  FIX make test_importances pass on 32 bit linux
  Release 0.19b1
  DOC remove 'in dev' header in whats_new.rst
  DOC typos in whats_news.rst [ci skip]
  [MRG] DOC cleaning up what's new for 0.19 (scikit-learn#9252)
  FIX t-SNE memory usage and many other optimizer issues (scikit-learn#9032)
  FIX broken link in gallery and bad title rendering
  [MRG] DOC Replace \acute by prime (scikit-learn#9332)
  Fix typos (scikit-learn#9320)
  [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (scikit-learn#9206)
  DOC Residual sum vs. regression sum (scikit-learn#9314)
  [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (scikit-learn#9317)
  More informative error message for classification metrics given regression output (scikit-learn#9275)
  [MRG] COSMIT Remove unused parameters in private functions (scikit-learn#9310)
  [MRG+1] Ridgecv normalize (scikit-learn#9302)
  [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (scikit-learn#7388)
  Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
  FIX makedirs(..., exists_ok) not available in Python 2 (scikit-learn#9284)
  ...
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017
@yarikoptic
Merge branch 'dfsg' into debian
236bb58 
* dfsg: (808 commits)
  Preparing 0.19b2
  [MRG+1] FIX out of bounds array access in SAGA (scikit-learn#9376)
  FIX make test_importances pass on 32 bit linux
  Release 0.19b1
  DOC remove 'in dev' header in whats_new.rst
  DOC typos in whats_news.rst [ci skip]
  [MRG] DOC cleaning up what's new for 0.19 (scikit-learn#9252)
  FIX t-SNE memory usage and many other optimizer issues (scikit-learn#9032)
  FIX broken link in gallery and bad title rendering
  [MRG] DOC Replace \acute by prime (scikit-learn#9332)
  Fix typos (scikit-learn#9320)
  [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (scikit-learn#9206)
  DOC Residual sum vs. regression sum (scikit-learn#9314)
  [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (scikit-learn#9317)
  More informative error message for classification metrics given regression output (scikit-learn#9275)
  [MRG] COSMIT Remove unused parameters in private functions (scikit-learn#9310)
  [MRG+1] Ridgecv normalize (scikit-learn#9302)
  [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (scikit-learn#7388)
  Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
  FIX makedirs(..., exists_ok) not available in Python 2 (scikit-learn#9284)
  ...
dmohns added a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@lesteve @dmohns
Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
9dbc9f2
dmohns added a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@lesteve @dmohns
Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
4b0248e
NelleV added a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@lesteve @NelleV
Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
e6384bf
paulha added a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@lesteve @paulha
Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
179e487
AishwaryaRK added a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017
@lesteve @AishwaryaRK
Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
a3ffc7d
@lesteve lesteve deleted the lesteve:add-data-home-to-fetch-kddcup99 branch Oct 20, 2017
maskani-moh added a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@lesteve @maskani-moh
Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
41ee3eb
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
@lesteve Jeremiah Johnson
Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
265a138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@lesteve @agramfort @TomDLT