Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Mixed Mode Tutorial #396

Merged
merged 13 commits into from Oct 1, 2020

Conversation

JAnderson419
Copy link
Contributor

Added a basic mixed mode conversion tutorial for documentation. Moved @jrmagers tutorial into a new "Mixed Mode Analysis" folder that includes both notebooks.

JAnderson419 and others added 11 commits January 16, 2020 22:44
Signed-off-by: Jackson Anderson <bookfreak419@gmail.com>
Signed-off-by: Jackson Anderson <bookfreak419@gmail.com>

# Conflicts:
#	doc/source/examples/circuit/Mixed Mode S and Impedance Transformation.ipynb
update mixed mode tutorial branch
Signed-off-by: Jackson Anderson <bookfreak419@gmail.com>
…dded to base repo

Signed-off-by: Jackson Anderson <bookfreak419@gmail.com>
Signed-off-by: Jackson Anderson <bookfreak419@gmail.com>
…per scikit-rf#367

Signed-off-by: Jackson Anderson <bookfreak419@gmail.com>
@jhillairet
Copy link
Member

Nice addition! Is it ready to be merged?

Signed-off-by: Jackson Anderson <bookfreak419@gmail.com>
@jhillairet jhillairet added the Documentation Request/Improvement of the documentation label Oct 1, 2020
Signed-off-by: Jackson Anderson <bookfreak419@gmail.com>
@JAnderson419
Copy link
Contributor Author

I think it is all ready on my end. I double checked @jrmagers notebook after moving it and I think it has all his changes updated as well (I started this branch a while back and had to merge his updates in).

@jhillairet jhillairet merged commit 5c0da71 into scikit-rf:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Request/Improvement of the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants