update fork #6
Merged
update fork #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added N.deembed property, set by the inv method - added code for deembedding noise correlation matrix caution : the noise of access network is also deembedded, possibly causing matrix invertion fails in case of highly non-reciprocal element (isolator) - moved code from read_touchstone() into function s_noise_a() - added nfdb_gs() method , handy for generating noise_contour plots TODO single point noise_frequency operation TODO : use s_noise_a() for noise parameter setters TODO correct a bug causing z0(freq) to seem constant added preliminary test retrieve the original network after deembed+cascade operations for both simple and noisy access path retrieve the original noise parameters from a basic optimum search noise contour plots needs polish TODO : comparison with ADS on non-trivial access network
rf.plotting.smith(chart_type='y', draw_labels=True) one sees that the labels for the real and imag part of the admittances are incorrect. The real part should go (from left to right from /infty to 0.0, and the imag part on the unit circle goes (clock wise) from \infty j over -j to 0, +j and back to \infty.
From the example given in the mailing list
Fix Admittance Smith chart labels
Thanks. I'd also added it into the development guide.
Since HFSS 2020R2, the gamma and z0 are written on a single line instead of many in the previous version. Add tests with multiport files added pathlib to the dependencies list for python 2 debug messages for Travis put decimals to integer before division removing the print in the test. Should be almost final now
Fix reading Gamma and Z0 information for Nport with N>8 for HFSS Touchstone files. Also implement the new Gamma and Z0 format (all inline) of the future HFSS version
moved tuner_constellation to NetworkSet
moved tuner_constellation to NetworkSet
…t format !! test_network.py
This reverts commit dce08f6.
…respectively tuner_constellation yielding a tuner object
…respectively - tuner_constellation yielding a NetworkSet object - tests on deembed for singlefreq and multifreq
Added noise deembedding feature (Preliminary work to be continuated). Thanks.
Need to make it work someday, eventually
add example: Mixed Mode S and Impedance Transformation.ipynb
CPW Media fix and new associated tests
Comments out unused matplotlib imports in network.py that result in problems when users try to use skrf without matplotlib installed (see #363)
remove unused matplotlib imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.