Fail building wheels from sdists on PyPI (v0.6.10)

[ccoulombe]

Hello,
When building ripser 0.6.10 from the PyPI sdists, it fails with

  src/ripser/pyRipser.cpp: In function ‘npy_intp __pyx_f_5numpy_5dtype_8itemsize_itemsize(PyArray_Descr*)’:
  src/ripser/pyRipser.cpp:3749:13: error: ‘PyDataType_ELSIZE’ was not declared in this scope; did you mean ‘PyDataType_ISUNSIZED’?
   3749 |   __pyx_r = PyDataType_ELSIZE(__pyx_v_self);
        |             ^~~~~~~~~~~~~~~~~
        |             PyDataType_ISUNSIZED

while using the release on Github works fine, or cloning the repo and checkout the v0.6.10.

[catanzaromj]

Hey @ccoulombe Sorry to hear that. Can you give some specifics on your environment, like OS and compiler?

It builds fine for me on Ubuntu 22.04 with g++ 11.4.0

[ccoulombe]

@catanzaromj
The environment is Centos, python 3.10 with GCC 12.3.
But after a second view, this looks more like an internal issue/incompatibility with our build environment as I cannot successfully reproduce the issue elsewhere.

For instance, using our modules for numpy (v1.21.2) fails, but installing the numpy in a virtual env. works as expected.

# fails
module load python/3.10 cython/.3.0.10 oldest-supported-numpy/.2024a 
pip wheel -v --no-deps --no-build-isolation https://files.pythonhosted.org/packages/c8/27/31ea7effa8a1cabd0f36962bb242eaa529577bec19157dfaaa983647caff/ripser-0.6.10.tar.gz

# works
module load python/3.10 cython/.3.0.10
virtualenv --no-download --clear ~/ENV && source ~/ENV/bin/activate 
pip install oldest-supported-numpy 
pip wheel --no-deps --no-build-isolation https://files.pythonhosted.org/packages/c8/27/31ea7effa8a1cabd0f36962bb242eaa529577bec19157dfaaa983647caff/ripser-0.6.10.tar.gz

What puzzle me is that using the source from GH works... I might circle back to this in September.
Sorry for the noise, I was a bit quick to open this issue as often the sdists on PyPI is incomplete or different from the release on GH (in general).

In the end, I used the source from GH so I was successful in building ripser.

[catanzaromj]

Thanks for the update @ccoulombe. When you circle back, feel free to re-open if you need some input from us.