Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Typo in scil_dti_metrics script #1000

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

AlexVCaron
Copy link
Contributor

@AlexVCaron AlexVCaron commented Jun 17, 2024

Quick description

scil_dti_metrics.py is unusable due to a typo in the script. I assume in the tests and most usages, we ask to output FA, and it must be why we didn't detect this error, since or shortcuts evaluating args.RGB.

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@EmmaRenauld EmmaRenauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I didn't check: would it be possible to change a test so that we get this?

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.27%. Comparing base (4e7047d) to head (0f4d6e0).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1000      +/-   ##
==========================================
+ Coverage   68.24%   68.27%   +0.02%     
==========================================
  Files         419      419              
  Lines       21391    21391              
  Branches     3209     3209              
==========================================
+ Hits        14599    14604       +5     
+ Misses       5530     5528       -2     
+ Partials     1262     1259       -3     
Components Coverage Δ
Scripts 69.25% <100.00%> (+0.03%) ⬆️
Library 66.86% <ø> (ø)

@EmmaRenauld
Copy link
Contributor

P.s. Numero 1000!!!!

@arnaudbore arnaudbore merged commit 920ec63 into scilus:master Jun 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants