Fix the unique len issue #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Failed 💥 |
|
The error is because of something in Python3.10, this should be merged with PR #662 |
|
Build Failed 💥 |
|
Build Failed 💥 |
|
Build passed ! Good Job 🍻 ! |
EmmaRenauld
approved these changes
Jan 23, 2023
| @@ -15,6 +15,7 @@ | |||
| import os | |||
|
|
|||
| import nibabel as nib | |||
| import numpy as np | |||
There was a problem hiding this comment.
@frheault quick fix and I merge + release.
|
Build passed ! Good Job 🍻 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
np.unique() was sorting the results and changing the length which was messing up the naming convention.
I discovered it while trying Tractoflow ABS and it was not working at ALL (the mask where all messed up).
I simply removed the np.unique() and now it is the job of the user to have a decent LUT