Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few warnings #748

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Fix a few warnings #748

merged 2 commits into from
Sep 27, 2023

Conversation

EmmaRenauld
Copy link
Contributor

Fixed my pycharm warnings.

  • Fixed "function X does not have a parameter X"
  • Fixed "unused imports"

@arnaudbore arnaudbore self-requested a review September 21, 2023 18:15
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

AntoineTheb
AntoineTheb approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@AntoineTheb AntoineTheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @EmmaRenauld, LGTM

arnaudbore
arnaudbore approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @EmmaRenauld

@arnaudbore arnaudbore merged commit 72c16c2 into scilus:master Sep 27, 2023
5 checks passed
@EmmaRenauld EmmaRenauld deleted the fix_my_pycharm_warnings branch October 11, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudbore arnaudbore arnaudbore approved these changes

@AntoineTheb AntoineTheb AntoineTheb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmmaRenauld @arnaudbore @AntoineTheb