Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken error handling #271

Closed
kormat opened this issue Jul 23, 2015 · 1 comment
Closed

Broken error handling #271

kormat opened this issue Jul 23, 2015 · 1 comment
Assignees
@kormat

Comments

@kormat
Copy link
Contributor

kormat commented Jul 23, 2015

A lot of the packet library prints a warning when it encounters a bad packet, which then causes code that relies on it to die in unexpected ways. A classic example is this:

https://gist.github.com/kormat/598e77bb164483d217e4

We need to do an error-handling audit to fix these cases with proper exceptions.
@kormat kormat self-assigned this Jul 23, 2015
@kormat kormat mentioned this issue Jul 24, 2015
Merged
2 tasks
@kormat
Copy link
Contributor Author

kormat commented Oct 30, 2015

Error handling is now greatly improved, closing.

@kormat kormat closed this as completed Oct 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kormat kormat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kormat