-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider pre-commit-ci/lite #104
Comments
Let's try this! Should we install it for one of repository and try there first? |
I just installed it for essnmx. |
Here is what I tested in Applied wrong format on purpose and pre-commit fixed themPre-commit CI made a commit with fixesFinal CI tests passes! |
I think it's very neat and we should use this one instead. |
And it actually ran the CI pipeline on the new commit! I'm happy with it, any objections @scipp/scipp-maintainers ? |
If I understand correctly, we could use https://github.com/pre-commit-ci/lite-action instead of the autocommit action to apply changes to PRs. This may work better than the current approach which creates a separate commit but doesn't run CI on it.
We'd still have to run pre-commit ourselves.
The text was updated successfully, but these errors were encountered: