-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review of "The Reference Model for Disease Progression" #4
Comments
The paper discusses the construction of a tool to compare a variety of different disease models. It describes the expression of models and populations and briefly touches on their simulation. In general it is a fine paper. It might be improved by showing a more cohesive use within the paper and discussing more about simulation techniques. Additionally, if the paper had been written today it might be appropriate to mention projects like PyMC3, which seem to occupy a somewhat similar space. Answers to all requested questions are generally affirmative, at least to my eye. |
Thanks to both reviewers Mathew and Christine for their insights. I followed the correction list of Christine Choirat who was very detailed. You can find a new version of the paper uploaded. Please find an easy way to include links to this discussion and reviews with the paper itself. Christine made two suggestions: I did not want to go into too much detail. So I added the following two sentences for the paper: "The simulation language presented here constrains the user from a certain perspective. However, it channels the flow of data in a structured way through the system. This constraining is an advantage for the task at hand since it allows providing proper feedback to the user within the disease modeling domain." However, the answer is much more elaborate. The availability of a Domain Specific Language (DSL) in this case allows for defining parameters, analyzing the population generation order to allow the user the freedom of defining population dependencies without writing them is execution order, constructing intelligent reports, and in the past, even estimating parameters for Markov Models. Nevertheless, it comes with constraints. I am sure that someone can create a better DSL with the current tools. II. How do you calibrate the Population Generator parameters? J. Barhak, The Reference Model for Disease Progression uses MIST to find data fitness. PyData Silicon Valley 2014 held at Facebook Headquarters: J. Barhak, A. Garrett, Population Generation from Statistics Using Genetic Algorithms with MIST + INSPYRED. MODSIM World 2014, April 15 - 17, Hampton Roads Convention Center in Hampton, VA. For the sake of keeping the timeline correct, I did not make any changes in the original SciPy paper, yet this response should give interested readers the proper direction. One clarification regarding the availability of code questions. The Reference Model is not released and in fact it has patent pending elements. Yet the modeling framework is fully available under GPL license - both the legacy IEST and its replacement MIST are free python software. MIST is available in: https://github.com/Jacob-Barhak/MIST Finally Mathew raised an interesting point regarding PyMC3. At a first glance it looks like an interesting tool. Yet it was not known to me or available when starting development. In fact, there are many other libraries that I could have used that are available today that would improve many aspects of this code. For example pandas for manipulating data, or ast for handling language issues come to mind. The fact that there are newer tools is actually great since it shows that the scientific python community is moving forwards. |
Reviewer: Christine Choirat
Center: Institute for Quantitative Social Science
University: Harvard University
Field of interest / expertise: Statistics, Statistical Programming
Country: USA
Article reviewed: The Reference Model for Disease Progression
GENERAL EVALUATION
Quality of the approach:
Quality of the writing:
Quality of the figures/tables:
SPECIFIC EVALUATION
Is the code made publicly available and does the article sufficiently
describe how to access it?
Does the article present the problem in an appropriate context?
explain why the problem is important,
describe in which situations it arises,
outline relevant previous work,
provide background information for non-experts
Is the content of the paper accessible to a computational scientist
with no specific knowledge in the given field?
Does the paper describe a well-formulated scientific or technical
achievement?
Are the technical and scientific decisions well-motivated and
clearly explained?
Are the code examples (if any) sound, clear, and well-written?
Is the paper factual correct?
Is the language and grammar of sufficient quality?
Are the conclusions justified?
Is prior work properly and fully cited?
Should any part of the article be shortened or expanded? Please explain.
Suggestions:
Explain the benefits of creating a simulation language vs Python functions.
How do you calibrate the Population Generator parameters?
In your view, is the paper fit for publication in the conference proceedings?
Please suggest specific improvements and indicate whether you think the
article needs a significant rewrite (rather than a minor revision).
The text was updated successfully, but these errors were encountered: