Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: sampling_tdr.rst failing in CircleCI smoke-tutorials job #21250

Closed
rgommers opened this issue Jul 24, 2024 · 4 comments · Fixed by #21271
Closed

DOC: sampling_tdr.rst failing in CircleCI smoke-tutorials job #21250

rgommers opened this issue Jul 24, 2024 · 4 comments · Fixed by #21271
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.stats
Milestone

Comments

@rgommers
Copy link
Member

Failure from this log:

doc/source/tutorial/stats/sampling_srou.rst x                            [ 96%]
doc/source/tutorial/stats/sampling_tdr.rst F                             [100%]

=================================== FAILURES ===================================
__________________________ [doctest] sampling_tdr.rst __________________________
154     527
155     >>> dist2 = StandardNormal()
156     >>> # use the same stream of uniform random numbers
157     >>> rng2 = TransformedDensityRejection(dist2, max_squeeze_hat_ratio=0.999,
158     ...                                    random_state=urng2)
159     >>> dist2.callbacks  # evaluations during setup
160     467
161     >>> dist2.callbacks = 0  # don't consider evaluations during setup
162     >>> rvs = rng2.rvs(100000)
163     >>> dist2.callbacks  # evaluations during sampling
Expected:
    84
Got:
    57

/home/circleci/repo/doc/source/tutorial/stats/sampling_tdr.rst:163: DocTestFailure
=========================== short test summary info ============================
FAILED doc/source/tutorial/stats/sampling_tdr.rst::sampling_tdr.rst
=================== 1 failed, 25 passed, 6 xfailed in 28.12s ===================

This tutorial was the first one to be converted to MyST-md (although it is 7 weeks ago, in gh-20303), so perhaps the seeding for the test machinery doesn't work anymore? @melissawm you may be able to say more here?

@github-actions github-actions bot added the CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure label Jul 24, 2024
@rgommers rgommers added Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org and removed CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure labels Jul 24, 2024
@lucascolley
Copy link
Member

at least recently, this failure was hidden by some smoke-docs failures (gh-21238), so it may have been failing silently for a little while

@lucascolley lucascolley changed the title sampling_tdr.rst failing in CircleCI smoke-tutorials job DOC: sampling_tdr.rst failing in CircleCI smoke-tutorials job Jul 24, 2024
@lobpcg
Copy link
Contributor

lobpcg commented Jul 25, 2024

@melissawm
Copy link
Member

melissawm commented Jul 25, 2024

I had to double check, but indeed we did not touch this tutorial (yet?): https://github.com/scipy/scipy/commits/main/doc/source/tutorial/stats/sampling_tdr.rst

This is still an rst file. Perhaps this has been silently failing for a while, and the failure is now being flagged by a new config in smoke-tests?

@ev-br
Copy link
Member

ev-br commented Jul 25, 2024

These sampling_*.rst tutorials are problematic in more than one way, can just add the failing one to the xfail list at
https://github.com/scipy/scipy/blob/main/scipy/conftest.py#L413

unless someone is up to fixing the actual problems, that is :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.stats
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants