MAINT: update numpydoc to v1.1.0 #13326
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue was annoying to track down. These are new warnings that showed up due to a change in numpydoc:
The root cause is that
dict
methods don't have proper html docs that can be found via intersphinx (see https://bugs.python.org/issue11975). That is fixed by ignoring reference issues for builtins in Sphinx, see sphinx-doc/sphinx#7254.It's not clear to me if the warnings appearing now is a regression in numpydoc, or a correct fix that made the issue show up. The two candidate changes in numpydoc that touched this behaviour are:
Maybe this means something to one of you?
I couldn't upgrade to numpydoc latest master due to another issue, but that's for another time.