Revert "ENH: sparse: Add _array version of diags creation functions…
#18599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scipy#18538)" This reverts commit 763a25e.
perimosocordiae
approved these changes
Jun 1, 2023
tylerjereddy
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
The 1 CI failure is an unrelated and intentional version bound check on the release branch, so that's fine.
CJ's approval is good enough for me, and it would indeed be helpful for sparse folks to check what I drafted in for the "Highlights" section of the release notes when they make any other adjustments..
I've already pushed the version bump to rc2 so in it goes, thanks.
tylerjereddy
added a commit
to tylerjereddy/scipy
that referenced
this pull request
Jun 15, 2023
* remove `diags_array` from release notes per scipygh-18599
3 tasks
tylerjereddy
added a commit
to tylerjereddy/scipy
that referenced
this pull request
Jun 16, 2023
* update the SciPy 1.11.0rc2 release notes following additional backports DOC: suggestions for `scipy.sparse` release notes Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Reword some sentences Remove mentions of n-dimensional sparse arrays Apply suggestions from code review DOC: update release notes for scipy.stats DOC: PR 18671 revisions * remove `diags_array` from release notes per scipygh-18599 DOC: PR 18671 revisions * update release notes after more activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…. (#18538)"
This reverts commit 763a25e.
@tylerjereddy @rossbar See #18592 (comment)