Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pep8ify stats/distributions.py #3126

Merged
merged 2 commits into from
Dec 6, 2013
Merged

Conversation

sotte
Copy link
Contributor

@sotte sotte commented Dec 5, 2013

While I was looking at distributions.py I fixed a few pep8 errors.

- mostly missing whitespace after ","
- linebreaks
- indentation
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 3eb848e on sotte:pep8_distributions into 5739a8b on scipy:master.

@argriffing
Copy link
Contributor

This python file distributions.py has grown so large that github is treating it as not human readable in some contexts, and I am inclined to agree.

@rgommers
Copy link
Member

rgommers commented Dec 6, 2013

Splitting it into three parts (core classes, continuous and discrete distributions) would be fine with me.

@argriffing
Copy link
Contributor

I'll merge this and then see what happens when I try to split the file into three parts.

argriffing added a commit that referenced this pull request Dec 6, 2013
@argriffing argriffing merged commit 47f10f7 into scipy:master Dec 6, 2013
@WarrenWeckesser
Copy link
Member

@rgommers wrote: Splitting it into three parts (core classes, continuous and discrete distributions) would be fine with me.

+1

@rgommers
Copy link
Member

rgommers commented Dec 6, 2013

Thanks @sotte!

@argriffing
Copy link
Contributor

Here is my attempt to split the distributions.py file: #3128

@sotte
Copy link
Contributor Author

sotte commented Dec 9, 2013

Thanks for the merge! Also nice to see that distributions.py is split now. Much better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants