pep8ify stats/distributions.py #3126

Merged
merged 2 commits into from Dec 6, 2013

Conversation

Projects
None yet
5 participants
@sotte
Contributor

sotte commented Dec 5, 2013

While I was looking at distributions.py I fixed a few pep8 errors.

sotte added some commits Dec 5, 2013

pep8ify distribution.py
- mostly missing whitespace after ","
- linebreaks
- indentation
@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Dec 5, 2013

Coverage Status

Coverage remained the same when pulling 3eb848e on sotte:pep8_distributions into 5739a8b on scipy:master.

Coverage Status

Coverage remained the same when pulling 3eb848e on sotte:pep8_distributions into 5739a8b on scipy:master.

@argriffing

This comment has been minimized.

Show comment Hide comment
@argriffing

argriffing Dec 6, 2013

Contributor

This python file distributions.py has grown so large that github is treating it as not human readable in some contexts, and I am inclined to agree.

Contributor

argriffing commented Dec 6, 2013

This python file distributions.py has grown so large that github is treating it as not human readable in some contexts, and I am inclined to agree.

@rgommers

This comment has been minimized.

Show comment Hide comment
@rgommers

rgommers Dec 6, 2013

Member

Splitting it into three parts (core classes, continuous and discrete distributions) would be fine with me.

Member

rgommers commented Dec 6, 2013

Splitting it into three parts (core classes, continuous and discrete distributions) would be fine with me.

@argriffing

This comment has been minimized.

Show comment Hide comment
@argriffing

argriffing Dec 6, 2013

Contributor

I'll merge this and then see what happens when I try to split the file into three parts.

Contributor

argriffing commented Dec 6, 2013

I'll merge this and then see what happens when I try to split the file into three parts.

argriffing added a commit that referenced this pull request Dec 6, 2013

@argriffing argriffing merged commit 47f10f7 into scipy:master Dec 6, 2013

1 check passed

default The Travis CI build passed
Details
@WarrenWeckesser

This comment has been minimized.

Show comment Hide comment
@WarrenWeckesser

WarrenWeckesser Dec 6, 2013

Member

@rgommers wrote: Splitting it into three parts (core classes, continuous and discrete distributions) would be fine with me.

+1

Member

WarrenWeckesser commented Dec 6, 2013

@rgommers wrote: Splitting it into three parts (core classes, continuous and discrete distributions) would be fine with me.

+1

@rgommers

This comment has been minimized.

Show comment Hide comment
@rgommers

rgommers Dec 6, 2013

Member

Thanks @sotte!

Member

rgommers commented Dec 6, 2013

Thanks @sotte!

@argriffing

This comment has been minimized.

Show comment Hide comment
@argriffing

argriffing Dec 6, 2013

Contributor

Here is my attempt to split the distributions.py file: #3128

Contributor

argriffing commented Dec 6, 2013

Here is my attempt to split the distributions.py file: #3128

@sotte

This comment has been minimized.

Show comment Hide comment
@sotte

sotte Dec 9, 2013

Contributor

Thanks for the merge! Also nice to see that distributions.py is split now. Much better!

Contributor

sotte commented Dec 9, 2013

Thanks for the merge! Also nice to see that distributions.py is split now. Much better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment