-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split distributions #3128
Split distributions #3128
Conversation
One of the Travis builds failed because pypi didn't provide mpmath in a timely manner Downloading/unpacking mpmath I'll check if closing the PR and re-opening will make Travis retry downloading mpmath. |
I haven't looked too closely at this yet, so I have just a quick initial comment: all the new files should be "private" modules (i.e. give the filenames an underscore prefix). We're trying to avoid the proliferation of public submodules, so unless there is a compelling reason, the default should be "private" for new modules. |
I deliberately used But if this is not a good idea then I will give them underscores. |
I'd rather not have more public modules. We already have |
I'm not sure this PR works. You need to copy paste, delete add in the same commit to preserve git history. Without blame it will be very painful to "maintain" distributions. |
OK, I've added underscore prefixes to the submodules. |
Closing, with the idea to make a new PR that is less awkwardly gitted |
Break the distributions.py file into three files. The scipy tests all pass for me, and I guess we will find out if they pass on Travis. The docstrings are built on the fly and I do not think this docstring generation code is tested.