Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3ninja should report errors if it can't write to disk #233

Closed
larsw opened this issue Sep 15, 2023 · 1 comment · Fixed by #234
Closed

s3ninja should report errors if it can't write to disk #233

larsw opened this issue Sep 15, 2023 · 1 comment · Fixed by #234

Comments

@larsw
Copy link

larsw commented Sep 15, 2023

I'm running the latest scireum/s3ninja docker image, and I've bound the /home/sirius/data directory to a directory on the host.

It would be wise to include information about the uid of the sirius user in the documentation (2000 - even if it isn't specified explicitly in the Dockerfile) and inform users that they need to ensure that the permissions/ownership is correct.

As of now, it reports "Bucket successfully created." even if it doesn't write anything to disk / show anything in the bucket list in the UI.
jakobvogel added a commit that referenced this issue Sep 18, 2023
@jakobvogel
Logs some i/o-related exceptions in the storage log ✍️
53630bb 
#233
jakobvogel added a commit that referenced this issue Sep 18, 2023
@jakobvogel
Generally returns success of bucket-related file ops 🛎️
cbccaa9 
#233
jakobvogel added a commit that referenced this issue Sep 18, 2023
@jakobvogel
Uses proper variables names 🧼
bcf7dd5 
`e` → `exception`/`ignored`
`p*` → `path*`/`childPath`
`s*` → `string*`
`b*` → `bytes*`
`i` → `index`

#233
jakobvogel added a commit that referenced this issue Sep 18, 2023
@jakobvogel
Handles FS access errors in UI 🥅
0c1b575 
#233
jakobvogel added a commit that referenced this issue Sep 18, 2023
@jakobvogel
Handles FS access errors in S3-style interface 🏰
db11b75 
#233
jakobvogel added a commit that referenced this issue Sep 18, 2023
@jakobvogel
Properly try-catches the stream as well, not just the channel 🚨
a45dc10 
#233
jakobvogel added a commit that referenced this issue Sep 18, 2023
@jakobvogel
Improves further variable names 🌟
7d6fd11 
`e` → `exception`
`m` → `matcher`
`props` → `clonedProperties`
`propsOut` → `outputStream`
`propsFile` → `propertiesFile`

#233
jakobvogel added a commit that referenced this issue Sep 18, 2023
@jakobvogel
Revises combine method 👷‍♀️
633c464 
Renames variable `raf` to a proper, meaningful `randomAccessToPart`, and inlines single-use `channel` variable.

#233
jakobvogel added a commit that referenced this issue Sep 18, 2023
@jakobvogel
Adds further error codes 📢
02b5bdb 
#233
jakobvogel added a commit that referenced this issue Sep 18, 2023
@jakobvogel
Provides documentation 📙
57c4e10 
#233
jakobvogel added a commit that referenced this issue Sep 18, 2023
@jakobvogel
Upgrades Sirius 🪐
a723651 
#233
jakobvogel added a commit that referenced this issue Sep 18, 2023
@jakobvogel
Throws error if attempting to delete a non-empty bucket 🎳
6db3ad9 
See https://docs.aws.amazon.com/AmazonS3/latest/API/API_DeleteBucket.html

#233
jakobvogel added a commit that referenced this issue Sep 18, 2023
@jakobvogel
Throws error if attempting to create an existing bucket 🪣
85b37b6 
See https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateBucket.html

#233
jakobvogel added a commit that referenced this issue Sep 18, 2023
@jakobvogel
Uses more explicit error message 🚨
ba8e16a 
#233
@jakobvogel jakobvogel mentioned this issue Sep 18, 2023
Merged
jakobvogel added a commit that referenced this issue Sep 18, 2023
@jakobvogel
Makes sure that each test is run in a clean state 🧺
ce1e173 
The tests currently sometimes leave stuff behind, possibly influencing other tests.

#233
jakobvogel added a commit that referenced this issue Sep 18, 2023
@jakobvogel
Fixes test cases to properly set up and clean up 🚧
b9a1792 
Test cases now assume an empty state in the beginning, as enforced by the new methods introduced in commit ce1e173.

#233
jakobvogel added a commit that referenced this issue Sep 19, 2023
@jakobvogel
Removes overly ambitious cleanup ⛑️
2fbef94 
#233
@jakobvogel
Copy link
Member

@hggh could you please have a look concerning the Dockerfile and/or documentation?

@jakobvogel jakobvogel reopened this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improves Error Handling scireum/s3ninja
2 participants
@larsw @jakobvogel