Throws error if attempting to create an existing bucket 🪣

See https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateBucket.html #233
scireum · Sep 18, 2023 · 85b37b6 · 85b37b6
1 parent 6db3ad9
commit 85b37b6
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/src/main/java/ninja/S3Dispatcher.java b/src/main/java/ninja/S3Dispatcher.java
@@ -93,6 +93,7 @@ public class S3Dispatcher implements WebDispatcher {
     private static final String ERROR_MULTIPART_UPLOAD_DOES_NOT_EXIST = "Multipart Upload does not exist";
     private static final String ERROR_BUCKET_DOES_NOT_EXIST = "Bucket does not exist";
     private static final String ERROR_BUCKET_IS_NOT_EMPTY = "Bucket is not empty";
+    private static final String ERROR_BUCKET_ALREADY_OWNED_BY_YOU = "Bucket already owned by you";
     private static final String ERROR_FILE_SYSTEM = "Problems with file system access";
     private static final String PATH_DELIMITER = "/";
 
@@ -486,6 +487,15 @@ private void bucket(WebContext webContext, String bucketName) {
                 webContext.respondWith().status(HttpResponseStatus.OK);
             }
         } else if (HttpMethod.PUT.equals(method)) {
+            if (bucket.exists()) {
+                signalObjectError(webContext,
+                                  bucketName,
+                                  null,
+                                  S3ErrorCode.BucketAlreadyOwnedByYou,
+                                  ERROR_BUCKET_ALREADY_OWNED_BY_YOU);
+                return;
+            }
+
             if (!bucket.create()) {
                 signalObjectError(webContext, bucketName, null, S3ErrorCode.InternalError, ERROR_FILE_SYSTEM);
                 return;