Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does check_session return True when canvas_user is in params? #20

Open
lacker opened this issue Dec 6, 2009 · 0 comments
Open

Why does check_session return True when canvas_user is in params? #20

lacker opened this issue Dec 6, 2009 · 0 comments

Comments

@lacker
Copy link

lacker commented Dec 6, 2009

I was using the require_login decorator and noticed that when people arrived at my app for the first time by clicking a link from a request, it wasn't asking them to allow access, and various pyfacebook calls were failing. I tracked this down to the part of check_session:

   elif 'canvas_user' in params:
        self.uid = params['canvas_user']
   else:
        return False
   return True

In this case there is a canvas_user but we don't have a valid session_key. Shouldn't that mean that check_session returns False, and thus the require_login decorator will redirect the user to allow access?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant