-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use auto-merge wrapper #311
Conversation
Pull Request validationSuccess🟢 CI - All checks have passed |
[test-all] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamacku The change looks good, only one think. The gather metadata is one test that succeded and therefore the CI is green, that is not true. Do you know, if it is possible to fix it?
@phracek The problem is that you don't have any tests that would trigger on PR submission automatically. I currently don't see how to handle this from the auto-merge side. But IMHO this is only a theoretical problem. In case when someone approves PR within seconds of its submission, then it is possible that it will be merged on the first run of auto-merge. But I think this will never happen. Once the Schedule auto-merge is finished, you will get proper CI status in a comment. |
[test] |
No description provided.