Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use auto-merge wrapper #311

Merged
merged 1 commit into from
Jul 19, 2024
Merged

ci: use auto-merge wrapper #311

merged 1 commit into from
Jul 19, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Jul 18, 2024

No description provided.

Copy link

github-actions bot commented Jul 18, 2024

Pull Request validation

Success

🟢 CI - All checks have passed
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved

@phracek
Copy link
Member

phracek commented Jul 18, 2024

[test-all]

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamacku The change looks good, only one think. The gather metadata is one test that succeded and therefore the CI is green, that is not true. Do you know, if it is possible to fix it?

@jamacku
Copy link
Member Author

jamacku commented Jul 18, 2024

@phracek The problem is that you don't have any tests that would trigger on PR submission automatically. I currently don't see how to handle this from the auto-merge side.

But IMHO this is only a theoretical problem. In case when someone approves PR within seconds of its submission, then it is possible that it will be merged on the first run of auto-merge. But I think this will never happen.

Once the Schedule auto-merge is finished, you will get proper CI status in a comment.

.github/workflows/auto-merge-on-demand.yml Outdated Show resolved Hide resolved
@phracek
Copy link
Member

phracek commented Jul 19, 2024

[test]

@jamacku jamacku merged commit 0a88cfe into sclorg:master Jul 19, 2024
13 checks passed
@jamacku jamacku deleted the wrapper branch July 19, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants