Feature/create gpg signatures #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using a Google Guice child injector to reduce the amount of injection dependencies for the GitRepositoryServiceResolver and the GitRepositoryServiceProvider.
This change introduces a GitChangesetConverterFactory to allow injections for the GitChangesetConverter.
…re.keyId and added DummyGPG for testing
# Conflicts: # CHANGELOG.md # yarn.lock
sdorra
requested changes
Aug 10, 2020
scm-webapp/src/main/java/sonia/scm/security/gpg/PublicKeyResource.java
Outdated
Show resolved
Hide resolved
scm-webapp/src/main/java/sonia/scm/security/gpg/PublicKeyStore.java
Outdated
Show resolved
Hide resolved
scm-core/src/main/java/sonia/scm/security/PublicKeyCreatedEvent.java
Outdated
Show resolved
Hide resolved
scm-core/src/main/java/sonia/scm/security/PublicKeyDeletedEvent.java
Outdated
Show resolved
Hide resolved
scm-core/src/main/java/sonia/scm/repository/spi/MergeCommandRequest.java
Outdated
Show resolved
Hide resolved
scm-core/src/main/java/sonia/scm/repository/spi/ModifyCommandRequest.java
Outdated
Show resolved
Hide resolved
sdorra
reviewed
Aug 10, 2020
# Conflicts: # CHANGELOG.md # scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/spi/GitHookContextProvider.java # scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/spi/GitLogCommand.java # scm-plugins/scm-git-plugin/src/main/java/sonia/scm/web/GitReceiveHook.java
sdorra
requested changes
Aug 12, 2020
scm-core/src/main/java/sonia/scm/repository/spi/ModifyCommandRequest.java
Outdated
Show resolved
Hide resolved
scm-webapp/src/main/java/sonia/scm/security/gpg/DefaultPrivateKey.java
Outdated
Show resolved
Hide resolved
scm-webapp/src/main/java/sonia/scm/security/gpg/GPGKeyPairGenerator.java
Outdated
Show resolved
Hide resolved
scm-webapp/src/main/java/sonia/scm/security/gpg/KeysExtractor.java
Outdated
Show resolved
Hide resolved
scm-webapp/src/main/java/sonia/scm/security/gpg/PublicKeyStore.java
Outdated
Show resolved
Hide resolved
scm-webapp/src/main/java/sonia/scm/security/gpg/PublicKeyStore.java
Outdated
Show resolved
Hide resolved
sdorra
reviewed
Aug 12, 2020
scm-ui/ui-components/src/repos/changesets/Changesets.stories.tsx
Outdated
Show resolved
Hide resolved
sdorra
reviewed
Aug 12, 2020
|
Please fix the sonarqube warnings. |
Pilopa
force-pushed
the
feature/create_gpg_signatures
branch
from
f9c3db1
to
a4d0ff2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
PR merges and commits performed through the SCM-Manager UI will now automatically be signed and verified with an automatically generated GPG key pair. Public keys can now be downloaded both from within the signature as well as in the public key management view by clicking on the key id.
Your checklist for this pull request
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Checklist for branch merge request (not required for forks)