Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/branch details #1876

Merged
merged 45 commits into from
Dec 1, 2021
Merged

Feature/branch details #1876

merged 45 commits into from
Dec 1, 2021

Conversation

eheimbuch
Copy link
Contributor

@eheimbuch eheimbuch commented Nov 29, 2021

Proposed changes

Enrich branch overview with more details like last committer and ahead/behind commits. Since calculating this information is pretty intense, we request it in chunks to prevent very long loading times. Also we cache the results in frontend and backend.

Contributor:

  • PR is well described and the description can be used as a commit message on squash
  • Related issues linked to PR if existing and labels set
  • New code is covered with unit tests
  • New ui components are tested inside the storybook (module ui-components only)
  • Changelog entry file created in gradle/changelog or CHANGELOG.md is updated for plugins
  • Feature has been tested with different permissions
  • Documentation updated (only necessary for new features or changed behaviour)

Reviewer:

  • The clean code principles are respected (CleanCode)
  • All new code/logic is implemented on the right spot / "Should this be done here?"
  • UI changes fits into the layout
  • The UI views / components are responsive (mobile views)
  • Correct translations are available

Checklist for branch merge request (not required for forks)

@eheimbuch eheimbuch added the enhancement New feature or request label Nov 29, 2021
@pfeuffer pfeuffer force-pushed the feature/branch_details branch 2 times, most recently from 1a7336f to daacfbd Compare December 1, 2021 09:24
@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability B 2 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

29.8% 29.8% Coverage
0.0% 0.0% Duplication

@eheimbuch eheimbuch merged commit 9cc134f into develop Dec 1, 2021
@eheimbuch eheimbuch deleted the feature/branch_details branch December 1, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants