Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable plugin management via CLI #2087

Merged
merged 12 commits into from
Jul 19, 2022
Merged

Enable plugin management via CLI #2087

merged 12 commits into from
Jul 19, 2022

Conversation

eheimbuch
Copy link
Contributor

@eheimbuch eheimbuch commented Jul 13, 2022 •
edited
Loading

Proposed changes

Add cli commands for plugin management.

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Contributor:

  • PR is well described and the description can be used as a commit message on squash
  • Related issues linked to PR if existing and labels set
  • New code is covered with unit tests
  • New/updated ui components are tested inside the storybook (module ui-components only)
  • Changelog entry file created in gradle/changelog
  • Feature has been tested with different permissions
  • Documentation updated (only necessary for new features or changed behaviour)

Reviewer:

  • The clean code principles are respected (CleanCode)
  • All new code/logic is implemented on the right spot / "Should this be done here?"
  • UI changes fits into the layout
  • The UI views / components are responsive (mobile views)
  • Correct translations are available

Checklist for branch merge request (not required for forks)

@eheimbuch eheimbuch added the enhancement New feature or request label Jul 13, 2022
@eheimbuch eheimbuch changed the title Feature/cli plugin management Enable plugin management via CLI Jul 13, 2022
@eheimbuch eheimbuch marked this pull request as ready for review July 13, 2022 20:52
@Pilopa
Copy link
Contributor

Pilopa commented Jul 18, 2022 •
edited by eheimbuch
Loading

Seems to be working, just those two small points are to be fixed:

  • Command group description is missing (at least the English one)
  • Typo in description for update-all

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

67.1% 67.1% Coverage
5.7% 5.7% Duplication

@Pilopa Pilopa merged commit fc28da9 into develop Jul 19, 2022
@Pilopa Pilopa deleted the feature/cli_plugin_management branch July 19, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eheimbuch @Pilopa