Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine Linux: Tests failing on latest release (v2.9) #312

Closed
oxr463 opened this issue Apr 30, 2019 · 7 comments
Closed

Alpine Linux: Tests failing on latest release (v2.9) #312

oxr463 opened this issue Apr 30, 2019 · 7 comments

Comments

@oxr463
Copy link

oxr463 commented Apr 30, 2019

I'm the maintainer of bash-completion for Alpine Linux,
and I have a few tests that are failing on the latest release:

  • arping - using version from iputils.
  • getconf - using version from musl libc.
  • iconv - same as above.
  • ifup/ifdown - using only version (as far as I know), from debian.

NOTE: I'm developing in an LXC container, so I'm assuming that's why ifup/ifdown are failing, the log mentions something about failing to run due to being in a Docker container.

See: https://gitlab.com/oxr463/aports/issues/31

log.txt

@scop
Copy link
Owner

scop commented Apr 30, 2019

I believe container stuff (thus arping and ifup/ifdown) and getconf are now taken care of in master per the above two commits, but I'm not sure what to do about iconv. It doesn't seem to recognize any options whatsoever, just responds with "unrecognized option" with all -* I've tried.

@oxr463
Copy link
Author

oxr463 commented Apr 30, 2019

I did some further digging, and apparently, there are functional differences between glibc and musl versions of iconv, (See: https://wiki.musl-libc.org/functional-differences-from-glibc.html#iconv).

Is there a way to force-skip a test? Not very familiar with iconv so I'm not really sure what is different.

@scop
Copy link
Owner

scop commented May 1, 2019

Sure, there may be that kind of functional differences but that doesn't mean it'd have to affect bash-completion in any way. Adding a skip for option completion because the musl one doesn't output an usage message we could use to parse options from: https://git.alpinelinux.org/aports/tree/main/musl/iconv.c

@oxr463
Copy link
Author

oxr463 commented May 1, 2019

Oh that's true. Sounds good to me!

scop added a commit that referenced this issue May 1, 2019
Such as on Alpine Linux (musl libc).

Refs #312
@scop
Copy link
Owner

scop commented May 1, 2019

Pretty much all of this should be taken care of in master, apart from killall/pidof failures which are tracked in #318.

@scop scop closed this as completed May 1, 2019
@oxr463
Copy link
Author

oxr463 commented May 1, 2019

Thanks!

algorythmic pushed a commit to algorythmic/bash-completion that referenced this issue Oct 7, 2019
algorythmic pushed a commit to algorythmic/bash-completion that referenced this issue Oct 7, 2019
algorythmic pushed a commit to algorythmic/bash-completion that referenced this issue Oct 7, 2019
Such as on Alpine Linux (musl libc).

Refs scop#312
@nh2
Copy link

nh2 commented Dec 2, 2019

Could you make a release? NixOS with musl also suffers from this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants