Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A user should be able to set default values through a config file #5

Closed
scopeta opened this issue Jul 8, 2020 · 2 comments
Closed

Comments

@scopeta
Copy link
Owner

scopeta commented Jul 8, 2020

Description

A user should be able to set default values through a config.file

Currently, the default values are set to common Pomodoro configuration (25,5,25 mins) and the user can change that behavior through command line arguments

@Arthurcn96
Copy link
Contributor

Hello There!

I was thinking about solving this issue and I was wondering:

  • Is it okay to create a 'fm.ini' as the config file?
  • Which command do you have in mind to save the values in the config file?

@scopeta
Copy link
Owner Author

scopeta commented Oct 6, 2020

Hey Arthur,
I was thinking about removing the following lines that set default values from the main .py file and move them to a fm.ini. 

NUM_ROUNDS = 3
LENGHT_ARGS = {"focus_time": 25, "short_break": 5, "long_break": 25}

Those are classic values for Pomodoro timers, but someone may want their default values increased to 30/ 45 mins focused sessions, or enjoy a 10 mins break ;)

What do you think about having another argument option (e.g. -s) that save the lastest values passed in the command line?

Thanks!
Fabio

@scopeta scopeta closed this as completed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants