Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pull strategy to always pull on page load #4

Closed
ScottG489 opened this issue Aug 31, 2022 · 3 comments
Closed

Change pull strategy to always pull on page load #4

ScottG489 opened this issue Aug 31, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@ScottG489
Copy link
Owner

If the backing docker image changes, it's never updated since we use pull=absent.

To make sure we use the most up to date image, we should always have the backend pull once, probably on page load, and then only pull if it's absent until the page is reloaded again.

@ScottG489
Copy link
Owner Author

To clarify, we still should use absent because if the backing image is removed while the page is loaded, it still needs to re-pull.

@ScottG489
Copy link
Owner Author

Rethinking this, this will cause initial page loads to be slower, and this is generally when we want things to be faster. When it refreshes every 30 mins we probably don't care that it takes a little longer.

Perhaps we should do an absent pull on initial page load, and then refreshes will do an always.

@ScottG489 ScottG489 added the enhancement New feature or request label Nov 11, 2022
@ScottG489
Copy link
Owner Author

Fixed by cacd900.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant