Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Logo from Chapters to main Sections (right side of the title) #63

Closed
aladwani opened this issue Dec 11, 2022 · 3 comments
Closed
Assignees
Labels
v1 Issue needs to be resolved for first iteration

Comments

@aladwani
Copy link
Collaborator

The chapter logo should be visible on the right side of the chapter title.
The logo should be added to the strapi backend (choose a logo per chapter / no must field)

@aladwani aladwani added V0.9 Last version before upload Offer needed labels Dec 11, 2022
@bodobraegger
Copy link
Collaborator

I can gladly test this out, but I imagine the right-hand side placement being messy for long titles - how to wrap the titles around the images? having the image precedence and fixed to the width of the left-margin of the title avoids this issue.

p.s.: For clarification purposes, let's stick to the existing terminology:
Sections with Chapters. No Subchapters.

@aladwani aladwani changed the title Change Logo from Subchapter to main chapter (right side of the title) Change Logo from Chapters to main chapter (right side of the title) Dec 20, 2022
@aladwani aladwani changed the title Change Logo from Chapters to main chapter (right side of the title) Change Logo from Chapters to main Sections (right side of the title) Dec 20, 2022
@aladwani
Copy link
Collaborator Author

we should do some tests with longer text. I did not thought about this issue :)

@bodobraegger bodobraegger added v1 Issue needs to be resolved for first iteration and removed V0.9 Last version before upload Offer needed labels Feb 3, 2023
@jimmylevell
Copy link
Collaborator

We consider this issue as resolved.

FYI: @broesmel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1 Issue needs to be resolved for first iteration
Projects
None yet
Development

No branches or pull requests

3 participants