convert event-related timestamps to new system #4633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goober5000
added
cleanup
Goober5000
force-pushed
the
event_and_goal_timestamps
branch
5 times, most recently
from
9a0734f
to
c072088
Compare
|
After extensive testing and fixing several bugs, this is now ready for review. |
This change covers just the timestamps associated with goals and events, for better review and isolation purposes. Follow-up to scp-fs2open#4569.
Goober5000
force-pushed
the
event_and_goal_timestamps
branch
from
c072088
to
06fc8c7
Compare
BMagnu
requested changes
Sep 21, 2022
BMagnu
approved these changes
Sep 21, 2022
Goober5000
added a commit
to Goober5000/fs2open.github.com
that referenced
this pull request
Nov 30, 2022
Two situations in the event timestamp life cycle, chain delays and event status delays, require accommodation for the timestamp-plus-interval case described in `mission_process_event()`. Commit 06fc8c7 applied the fix for chain delays; this applies the same fix to event status delays. Follow-up to scp-fs2open#4633. Fixes scp-fs2open#4951.
Goober5000
added a commit
to Goober5000/fs2open.github.com
that referenced
this pull request
Aug 7, 2024
Fix units are denominated in seconds, while timestamp units are denominated in milliseconds. This fixes the directive timing check which, after the timestamp upgrade, would time out after 5 and 7 milliseconds instead of 5 and 7 seconds. Follow-up to scp-fs2open#4633.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change covers just the timestamps associated with goals and events, for better review and isolation purposes.
Follow-up to #4569.