Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pumpkin halloween fact #262

Merged
merged 3 commits into from Oct 30, 2018
Merged

Conversation

StenBone
Copy link
Contributor

@StenBone StenBone commented Oct 28, 2018

How Many Days Until Halloween? PR Request Template

Please note: Has this feature already been added? No

Pumpkin Halloween Fact

Type of Change was Made?

What type of change does your code introduce? After creating the PR, tick the checkboxes that apply.

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Description of the Change Being Made.

Simple addition of a pumpkin Halloween fact.

Issue Number #226

Potential Performance Issues

None

Tests/Checks

None

New Dependencies

None

Added a fact about pumpkins.
@scrabill
Copy link
Owner

@BitBoy92 Hey! Looks like this fact already exists (currently on line 21). Can you find a new one to add?

@scrabill scrabill added clarification For outstanding questions or where details are needed before merge working on it I see this and am working on testing before merging into the master branch labels Oct 29, 2018
Updated fact at the request of the repository owner.
@StenBone
Copy link
Contributor Author

@BitBoy92 Hey! Looks like this fact already exists (currently on line 21). Can you find a new one to add?

I chose a new fact. I believe this new one is unique. :)

@scrabill scrabill merged commit e7f6b52 into scrabill:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification For outstanding questions or where details are needed before merge working on it I see this and am working on testing before merging into the master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants